[ENHANCEMENT] Use secret in the proxy #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
7714860 to
dd938c5
Compare
27fe346 to
5b8cf90
Compare
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
5b8cf90 to
24008d1
Compare
celian-garcia
approved these changes
Aug 23, 2023
| } | ||
|
|
||
| func (e *Proxy) getProjectSecret(projectName string, dtsName string, name string) (*v1.SecretSpec, error) { | ||
| scrt, err := e.Secret.Get(projectName, name) |
There was a problem hiding this comment.
sometimes I hate Golang ...
Sign up for
5FA7
free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the usage of the secret in the proxy.
I have also a bit refactor how the proxy middleware is designed. It doesn't change that much but I think the new different steps makes more sense.
Alors introducing a struct will be the occasion for later to introduce a cache to avoid to get the datasource each time from the database. The redirection to the datasource will be then faster