8000 [ENHANCEMENT] Hide and encrypt sensitive data coming from the datasource spec by Nexucis · Pull Request #1378 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] Hide and encrypt sensitive data coming from the datasource spec #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 7, 2023
Merged

[ENHANCEMENT] Hide and encrypt sensitive data coming from the datasource spec #1378

merged 8 commits into from
Sep 7, 2023

Conversation

Nexucis
Copy link
Member
@Nexucis Nexucis commented Aug 24, 2023 •
edited
Loading

This PR is introducing the notion of public secret where the data is hidden when returned by the API to the user.
It also contains a way to encrypt and decrypt the sensitive data when it's necessary

@Nexucis Nexucis changed the title [ENHANCEMENT] Hide sensitive key on secret when request is answered [ENHANCEMENT] Hide sensitive key in secret when request is answered Aug 24, 2023
@Nexucis Nexucis marked this pull request as draft August 24, 2023 09:40
@Nexucis Nexucis force-pushed the nexucis/hidden_secret branch 2 times, most recently from 68cdfd0 to cbab568 Compare August 29, 2023 09:09
@Nexucis
[ENHANCEMENT] Hide sensitive key on secret when request is answered
5b65176 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis
split e2e test between write and read scenario
1857bfa 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the nexucis/hidden_secret branch from cbab568 to 1344d39 Compare September 4, 2023 09:02
@Nexucis
inject an expected result in the e2e test
48fddd8 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the nexucis/hidden_secret branch from 1344d39 to 48fddd8 Compare September 4, 2023 09:12
@Nexucis
fix e2e test
90e2e3f 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis marked this pull request as ready for review September 5, 2023 08:42
@Nexucis
encrypt/decrypt secret
f286306 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the nexucis/hidden_secret branch from b249052 to f286306 Compare September 5, 2023 14:35
@Nexucis
generate string for the key when it's empty
ee0a555 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis changed the title [ENHANCEMENT] Hide sensitive key in secret when request is answered [ENHANCEMENT] Hide and encrypt sensitive data coming from the datasource spec Sep 6, 2023
@Nexucis
read credential file in proxy
2b2bf8b 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
AntoineThebaud
AntoineThebaud approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nexucis
missing crypto injection in proxy
7e2903c 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis merged commit ac9ca4c into main Sep 7, 2023
@Nexucis Nexucis deleted the nexucis/hidden_secret branch September 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nexucis @AntoineThebaud
0