[ENHANCEMENT] Add a new key password_file in the sql config #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gladorme
requested changes
Aug 21, 2023
internal/api/config/database.go
Outdated
| @@ -49,6 +50,8 @@ type SQL struct { | |||
| User config.Secret `json:"user,omitempty" yaml:"user,omitempty"` | |||
| // Password (requires User) | |||
| Password config.Secret `json:"password,omitempty" yaml:"password,omitempty"` | |||
| // PasswordFile is a path to a file that contains a password | |||
| PasswordFile string `json:"password_file" yaml:"password_file"` | |||
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
48c853d to
e4b72bb
Compare
Gladorme
approved these changes
Aug 21, 2023
nicolastakashi
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a new key
password_filein the backend config so we can read a file that contains the password for the sql config.This is part of the issue #1368
/cc @nicolastakashi