[BUGFIX] Fix BE/FE misalignement on threshold datamodel #1389 #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AntoineThebaud <antoine.thebaud@yahoo.fr>
6689744 to
d7ea42e
Compare
AntoineThebaud
commented
Aug 30, 2023
| async toggleThresholdModes(mode: 'Absolute' | 'Percent') { | ||
| await this.container.getByRole('button', { name: mode === 'Percent' ? 'percent' : 'absolute' }).click(); | ||
| async toggleThresholdModes(mode: 'absolute' | 'percent') { | ||
| await this.container.getByRole('button', { name: mode === 'percent' ? 'Percent' : 'Absolute' }).click(); |
There was a problem hiding this comment.
the display remains with capitalized string, hence this selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed casing for thresholds mode to kebab-case on frontend side, to align with the backend datamodel. (This was basically missed in #1262).
This fixes #1389.
Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,IGNORE.