8000 [BUGFIX] Fix panel preview unresponsive after query error by AntoineThebaud · Pull Request #1418 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] Fix panel preview unresponsive after query error #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

[BUGFIX] Fix panel preview unresponsive after query error #1418

merged 1 commit into from
Sep 8, 2023

Conversation

AntoineThebaud
Copy link
Contributor
@AntoineThebaud AntoineThebaud commented Sep 8, 2023 •
edited
Loading

Description

Fixes #1342.
Fixes #1402.

This bug was most probably introduced with #1032, since before this the queries definition was located within the panel's plugin spec, thus relying on plugin.spec as resetKeys for the ErrorBoundary component was fine at this time.

Screenshots

2023-09-08_15h22_40.mp4

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant cha 8000 nges.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky. See Storybook and e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@AntoineThebaud
[BUGFIX] Fix panel preview unresponsive after query error
4a2d13a 
Signed-off-by: AntoineThebaud <antoine.thebaud@yahoo.fr>
celian-garcia
celian-garcia approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member
@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple that it couldn't break anything (WRONG!)
=> Approved

@AntoineThebaud AntoineThebaud merged commit 4c4f74e into main Sep 8, 2023
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/fix-panel-preview-unresponsive branch September 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celian-garcia celian-garcia celian-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panel preview stops refreshing after datasource query error Query editor error can cause panel preview to be unresponsive
2 participants
@AntoineThebaud @celian-garcia
0