[ENHANCEMENT] Autocomplete project name in the migration page #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Gladorme
reviewed
Sep 12, 2023
| @@ -148,18 +152,27 @@ function MigrateView() { | |||
| {migrateMutation.error.message} | |||
| </Alert> | |||
| )} | |||
| {migrateMutation.isSuccess && ( | |||
| <Stack direction={'row'} spacing={1}> | |||
| {!isLoading && data !== undefined && data !== null && migrateMutation.isSuccess && ( | |||
There was a problem hiding this comment.
{!isLoading && data && migrateMutation.isSuccess && (
There was a problem hiding this comment.
I am following the Perses UI guidelines here:
Use explicit
nullorundefinedchecks instead of relying on JS falsiness
AntoineThebaud
approved these changes
Sep 12, 2023
Gladorme
reviewed
Sep 12, 2023
Gladorme
reviewed
Sep 12, 2023
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
906c42a to
344bf5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding an autocompletion for the project name in the migration page. It's one of the two things needed for #1364