8000 [FEATURE] display the server config by Nexucis · Pull Request #1496 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FEATURE] display the server config #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2023
Merged

[FEATURE] display the server config #1496

merged 4 commits into from
Oct 20, 2023

Conversation

Nexucis
Copy link
Member
@Nexucis Nexucis commented Oct 20, 2023 •
edited
Loading

This PR is adding a new page to display the backend config.

Maybe we should put every button in a menu on the right corner.

I took the opportunity to split the breadcrumbs wrapper we have in two different components. I changed also the icon for the admin panel

image

@Nexucis Nexucis marked this pull request as draft October 20, 2023 08:52
@Nexucis Nexucis changed the title [IGNORE] update config interface in the UI app [FEATURE] display the server config Oct 20, 2023
@Nexucis Nexucis marked this pull request as ready for review October 20, 2023 10:07
@Nexucis
[IGNORE] update config interface in the UI app
f790926 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis
add config page
b0c1fa3 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
AntoineThebaud
AntoineThebaud approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this! I think it would be better to display it in YAML rather than JSON, but we dont have a ready-to-use component for this.

Gladorme
Gladorme reviewed Oct 20, 2023
View reviewed changes
@Gladorme
Copy link
Member

Not a huge fan of add "Config" to the navbar like this, as you said it will be probably better on the right.

@Nexucis
apply review
3e9da0e 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis
JSONEditor for config should be in readonly
b90b2e2 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis merged commit 16b1d31 into main Oct 20, 2023
@Nexucis Nexucis deleted the nexucis/ts-config branch October 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gladorme Gladorme Gladorme approved these changes

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nexucis @Gladorme @AntoineThebaud
0