-
Notifications
You must be signed in to change notification settings - Fork 101
[ENHANCEMENT] Reduce navbars size #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64a4724
to
7d48c7c
Compare
'&': { | ||
minHeight: '40px', | ||
paddingLeft: 0, | ||
paddingRight: 0.75, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddingRight: 0.75, | |
paddingRight: 2, |
In order to have the same padding as "body" content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hover effect size is pretty annoying, ok for me
I think, we could also remove the paddingTop of |
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
7d48c7c
to
f574553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
by the way does it reduce the navbar size of the variable ? |
You mean the sticky bar I assume? Then yes, actually my bad I forgot to put a screenshot for this one, you can see one now in the PR description. |
Much much better 🥳 |
Description
Reduce the size of the various navbars (top one, the one with breadcrumb & timerange controls in read mode, the one with variables dropdowns & timerange controls in edit mode, also the sticky version of the latter) to spare vertical space for the dashboard content.
Screenshots
before/after comparison:
Checklist
[<catalog_entry>] <commit message>
naming convention using one of the followingcatalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,IGNORE
.UI Changes