10000 [ENHANCEMENT] align recently dash view table by nicolastakashi · Pull Request #1504 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] align recently dash view table #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

[ENHANCEMENT] align recently dash view table #1504

merged 1 commit into from
Oct 23, 2023

Conversation

nicolastakashi
Copy link
Collaborator
@nicolastakashi nicolastakashi commented Oct 21, 2023 •
edited
Loading

Description

Align recently dash view table with left side table.

Screenshots

Before

image

After

image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky. See Storybook and e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@nicolastakashi nicolastakashi marked this pull request as ready for review October 22, 2023 19:09
AntoineThebaud
AntoineThebaud approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if there's a better solution to avoid this magic number of 3% for top margin, anyway that's good enough for the time being imho.

Nexucis
Nexucis approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! So cool you have the pixel perfect in the eyes !!

@nicolastakashi
Copy link
Collaborator Author

LGTM, I wonder if there's a better solution to avoid this magic number of 3% for top margin, anyway that's good enough for the time being imho.

Me too!
There're two magical number which I'd like to avoid, but I don't have a better idea :(

Gladorme
Gladorme reviewed Oct 23, 2023
View reviewed changes
Gladorme
Gladorme approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member
@Gladorme Gladorme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahahaha, in my last PR I did something similar, but yours is better with cards aligned (PR) 🤫

LGTM! Margin 3% can be replaced by "basic" number 😄

@nicolastakashi nicolastakashi force-pushed the chore/align-recently-view-table branch from ddf19ac to 6f87ded Compare October 23, 2023 10:27
@nicolastakashi
[CHORE] align align recently dash view table
805f269 
Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
@nicolastakashi nicolastakashi force-pushed the chore/align-recently-view-table branch from 6f87ded to 805f269 Compare October 23, 2023 10:28
@nicolastakashi nicolastakashi merged commit a8620d1 into perses:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

@Gladorme Gladorme Gladorme approved these changes

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

@celian-garcia celian-garcia Awaiting requested review from celian-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolastakashi @Nexucis @Gladorme @AntoineThebaud
0