[IGNORE] push docker image on the main branch #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
AntoineThebaud
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is enabling the possibility to push the docker image built on the main branch.
With that we can try any commit available on the upstream.
I refactor a bit the script
generate-goreleaserto have something a bit cleaner and easier to test.The idea here is to generate the docker image with the tag
main-<date>-<short_commit_id>-<distrib>-<arch>For example:
docker.io/persesdev/perses:main-2023-10-23-8b1f5d3f-distroless-debug-arm64Then since we are generating different image depending on the architecture (arm, amd), we need to create and push the manifest so we can pull the docker image easily