8000 [FEATURE] Add Role, RoleBinding, GlobalRole and GlobalRoleBinding kinds by Gladorme · Pull Request #1511 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FEATURE] Add Role, RoleBinding, GlobalRole and GlobalRoleBinding kinds #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2023
Merged

[FEATURE] Add Role, RoleBinding, GlobalRole and GlobalRoleBinding kinds #1511

merged 3 commits into from
Oct 30, 2023

Conversation

Gladorme
Copy link
Member
@Gladorme Gladorme commented Oct 24, 2023 •
edited
Loading

Description

Add Role, RoleBinding, GlobalRole and GlobalRoleBinding kinds for futur authorization as describe in the doc to the backend

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
  • All commits have DCO signoffs.

@Gladorme Gladorme force-pushed the gladorme/permissions branch 4 times, most recently from 07856f1 to 05d5970 Compare October 24, 2023 15:32
@Gladorme Gladorme changed the base branch from main to feature/permission-management October 24, 2023 15:33
@Gladorme Gladorme force-pushed the gladorme/permissions branch 6 times, most recently from 9e36a0a to 739b663 Compare October 25, 2023 14:11
@Gladorme Gladorme changed the title [FEATURE] Add authorization (backend) [FEATURE] Add Role, RoleBinding, GlobalRole and GlobalRoleBinding kinds Oct 25, 2023
@Gladorme Gladorme force-pushed the gladorme/permissions branch 6 times, most recently from 3f91e04 to 95836b8 Compare October 26, 2023 09:35
@Gladorme Gladorme marked this pull request as ready for review October 26, 2023 09:39
@Gladorme
[FEATURE] Add permissions to users
85585cc 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/permissions branch from 95836b8 to 85585cc Compare October 26, 2023 09:47
Nexucis
Nexucis reviewed Oct 27, 2023
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this (huge ;)) PR. I think I hope I covered everything !
Let me know if you have further questions.

@Gladorme
[IGNORE] Apply PR review
6fd2d6a 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/permissions branch from 2a2a828 to 054a692 Compare October 30, 2023 10:46
@Gladorme
[IGNORE] Perm Action to Actions
8000
305ec8a 
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme force-pushed the gladorme/permissions branch from 054a692 to 305ec8a Compare October 30, 2023 10:54
Nexucis
Nexucis approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done :)

@Gladorme Gladorme merged commit b24bb46 into feature/permission-management Oct 30, 2023
@Gladorme Gladorme deleted the gladorme/permissions branch October 30, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gladorme @Nexucis
0