8000 [ENHANCEMENT] Panel editor: reposition Add Query button for better UX by AntoineThebaud · Pull Request #1588 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] Panel editor: reposition Add Query button for better UX #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

[ENHANCEMENT] Panel editor: reposition Add Query button for better UX #1588

merged 1 commit into from
Nov 14, 2023

Conversation

AntoineThebaud
Copy link
Contributor
@AntoineThebaud AntoineThebaud commented Nov 14, 2023 •
edited
Loading

Description

Move the Add Query button in the Panel editor from top-right to bottom-left. It doesn't change much when you have 1 query defined or 2, but avoids lots of scrolling when you start to have more.

Screenshots

image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky. See Storybook and e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@AntoineThebaud
[ENHANCEMENT] Panel editor: reposition Add Query button for better UX
a7aaeeb 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud enabled auto-merge (squash) November 14, 2023 16:55
@AntoineThebaud AntoineThebaud merged commit 5be06d4 into main Nov 14, 2023
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/adjust-query-btn branch November 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gladorme Gladorme Gladorme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineThebaud @Gladorme
0