[ENHANCEMENT] Use a context for the config to share it across the whole app #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gladorme
reviewed
Nov 27, 2023
ui/app/src/context/Config.tsx
Outdated
| export function ConfigContextProvider(props: { children: React.ReactNode }) { | ||
| const { data, isLoading } = useConfig(); | ||
| if (isLoading || data === undefined) { | ||
| return <></>; |
There was a problem hiding this comment.
Suggested change
| return <></>; | |
| return <Stack width="100%" sx={{ alignItems: 'center', justifyContent: 'center' }}> | |
| <CircularProgress /> | |
| </Stack>; |
There was a problem hiding this comment.
okey. I just wished we would have the Perses logo animated instead of the MUI spinner 😢
…le app Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
c5fec4b to
2980088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just refactoring the way to access the config. I'm introducing a context so the different component can have access to the config without having to deal with async and network issue.
Today the config is already heavily use and I think it makes sense to simplify the usage and its access of it.
I find the code cleaner with this way (but perhaps it's just matter of test ;))