8000 [BUGFIX] OAuth/OIDC get redirect_uri from request considering X-Forwarded-* headers + guess scheme from request.TLS by celian-garcia · Pull Request #1706 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] OAuth/OIDC get redirect_uri from request considering X-Forwarded-* headers + guess scheme from request.TLS #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

[BUGFIX] OAuth/OIDC get redirect_uri from request considering X-Forwarded-* headers + guess scheme from request.TLS #1706

merged 1 commit into from
Jan 16, 2024

Conversation

celian-garcia
Copy link
Member

Description

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@celian-garcia
[BUGFIX] OAuth/OIDC get redirect_uri from request considering X-Forwa…
8d4f8e0 
…rded-* headers + guess scheme from request.TLS

Signed-off-by: Celian GARCIA <celian.garcia@amadeus.com>
@celian-garcia celian-garcia requested a review from Nexucis January 16, 2024 09:58
Nexucis
Nexucis approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@Nexucis Nexucis merged commit 176d3e1 into perses:release/v0.43 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celian-garcia @Nexucis
0