8000 [ENHANCEMENT] Improve the query editor's look by AntoineThebaud · Pull Request #2299 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] Improve the query editor's look #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2024
Merged

[ENHANCEMENT] Improve the query editor's look #2299

merged 4 commits into from
Oct 3, 2024

Conversation

AntoineThebaud
Copy link
Contributor
@AntoineThebaud AntoineThebaud commented Oct 3, 2024 •
edited
Loading

Description

  • Added a textfield-like like label for the promQL input + placeholder text
  • Consistent spacing between elements
  • Rework Legend's texts

There's still room for improvements (e.g label's background)

Screenshots

EDIT: gave up on rounded corner for the CodeMirror component since, for maintainability reasons.

Before After
image 2024-10-03_13h05_07
2024-10-03_13h07_17 2024-10-03_13h08_10

EDIT: with latest changes:
image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@AntoineThebaud
[ENHANCEMENT] Improve the query editor's look
3798d1c 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review October 3, 2024 11:15
@AntoineThebaud
rollback on rounded corners
cb5715f 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Fix missing capital letter
48d2f35 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Rework the Legend field's texts
cd0e7b4 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit a403f64 Oct 3, 2024
18 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/promql-editor-ph-and-label branch October 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

@Gladorme Gladorme Gladorme approved these changes

@celian-garcia celian-garcia celian-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntoineThebaud @Nexucis @Gladorme @celian-garcia
< 2A5E /div>
0