[ENHANCEMENT] Update configuration md file also oauth helper #2329
Conversation
Signed-off-by: Buatois Florian <buatois.florian@gmail.com>
perses#2322) Signed-off-by: Buatois Florian <buatois.florian@gmail.com>
| ```yaml | ||
| authentication: | ||
| providers: | ||
| oauth: |
There was a problem hiding this comment.
Did you try with oidc? I believe that if oidc works, giving just the issuer URL would be simpler than all the URLs one by one
| @@ -84,4 +84,8 @@ type TLSConfig struct { | |||
| ServerName string `yaml:"serverName,omitempty" json:"serverName,omitempty"` | |||
| // Disable target certificate validation. | |||
| InsecureSkipVerify bool `yaml:"insecureSkipVerify" json:"insecureSkipVerify"` | |||
| // Minimum acceptable TLS version. | |||
| MinVersion string `yaml:"minVersion" json:"minVersion" default:"TLS12"` | |||
There was a problem hiding this comment.
😲 is that default really working? I'd doubt that the config library take it into account. Specially if you use env variable to configure as lamenv library doesn't support it for sure.
We always use the verify method to setup defaults. I think for the env var and for consistency, we should use the same here.
There was a problem hiding this comment.
default doesn't work. I just tried with go playground.
If we want to define a default value we will have to override the method Unmarshal of the yaml and json package + define the Verify the method for the Perses config
|
@Labiote would you like to finish this PR ? |
|
@Labiote any chance you would like to update this PR ? It's been a while I know and documentations has changed since, but these changes are still accurate I believe. |
Description
Pull request for : #2322
Updating
configuration.mdto have correct parameters names. Also updatingoauth-configuration-helpers.mdto have an example of keycloak authentication with no tls. Also updating TLSConfig builder to use MinVersion and MaxVersion parameters instead of default ones.Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See Storybook
and e2e docs for more details. Common issues
include: