8000 [BUGFIX] TraceTable: expand the span count bubble in the service name chips by andreasgerstmayr · Pull Request #2368 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] TraceTable: expand the span count bubble in the service name chips #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

[BUGFIX] TraceTable: expand the span count bubble in the service name chips #2368

merged 2 commits into from
Oct 24, 2024

Conversation

andreasgerstmayr
Copy link
Contributor

Description

TraceTable: expand the span count bubble in the service name chips

Screenshots

Before:
image

After:
image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@andreasgerstmayr
[BUGFIX] TraceTable: expand the span count bubble in the service name…
67a1aa2 
… chips

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Gladorme
Gladorme reviewed Oct 23, 2024
View reviewed changes
Gladorme
Gladorme approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member
@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@andreasgerstmayr @Gladorme
Update ui/panels-plugin/src/plugins/trace-table/DataTable.tsx
7eed211
8000 
Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
celian-garcia
celian-garcia approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member
@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No brainer

@andreasgerstmayr andreasgerstmayr added this pull request to the merge queue Oct 24, 2024
Merged via the queue into perses:main with commit 81729d1 Oct 24, 2024
18 checks passed
@andreasgerstmayr andreasgerstmayr deleted the trace-table-span-count branch October 24, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gladorme Gladorme Gladorme approved these changes

@celian-garcia celian-garcia celian-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreasgerstmayr @Gladorme @celian-garcia
0