[ENHANCEMENT] Add decimal migrations; Add barchart migration #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the enhancement! Do you mind to target the branch release/v0.49 @7840vz ? Like that we can include it in the next rc for the v0.49.0 :) |
|
done |
|
would you mind to rebase your PR base on the new branch ? There are some commit that are not related to your PR here |
Signed-off-by: 7840vz <7840vz@users.noreply.github.com>
Signed-off-by: 7840vz <7840vz@users.noreply.github.com>
|
rebased. |
|
awesome thank you @7840vz ! |
There was a problem hiding this comment.
Thanks for doing that! Could you just please add a unit test covering the barchart panel migration? Here 'would be better to add a new test with a new grafana json containing a single barchart panel only, rather than appending stuff to the simple_grafana_dashboard which is quite big already
|
This PR closes #1525. |
|
Added test |
Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com>
abelyakin
pushed a commit
to abelyakin/perses
that referenced
this pull request
Dec 2, 2024
…2386) * Add barchart migration Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Update test Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Fix test Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Add test Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> * Update test Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> --------- Signed-off-by: 7840vz <7840vz@users.noreply.github.com> Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> Co-authored-by: 7840vz <7840vz@users.noreply.github.com>
abelyakin
pushed a commit
to abelyakin/perses
that referenced
this pull request
Dec 4, 2024
…2386) * Add barchart migration Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Update test Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Fix test Signed-off-by: 7840vz <7840vz@users.noreply.github.com> * Add test Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> * Update test Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> --------- Signed-off-by: 7840vz <7840vz@users.noreply.github.com> Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com> Co-authored-by: 7840vz <7840vz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds bargauge->barchart migration and decimal places migration.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.