8000 [ENHANCEMENT] migrate current.value to defaultValue by 7840vz · Pull Request #2406 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] migrate current.value to defaultValue #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

[ENHANCEMENT] migrate current.value to defaultValue #2406

merged 1 commit into from
Nov 7, 2024

Conversation

7840vz
Copy link
Contributor
@7840vz 7840vz commented Nov 7, 2024 •
edited
Loading

Description

Migrates current value to defaultValue in dashboard variables. This specifically useful for special values like $__all which can be set by default in Grafana.

NOTE: this is a copy of automatically closed #2383, but I removed the part that sets defaultValue to $__all if default value was missing in Grafana at all.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@7840vz
Migrate defaultValue
fb6b9dd 
Signed-off-by: 7840vz <122374011+7840vz@users.noreply.github.com>
AntoineThebaud
AntoineThebaud approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor
@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@AntoineThebaud AntoineThebaud added this pull request to the merge queue Nov 7, 2024
Merged via the queue into perses:main with commit 5a36ede Nov 7, 2024
18 checks passed
@7840vz 7840vz deleted the patch-6 branch November 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineThebaud AntoineThebaud AntoineThebaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7840vz @AntoineThebaud
0