8000 [FEATURE] add remote loader for runtime plugins by jgbernalp · Pull Request #2514 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FEATURE] add remote loader for runtime plugins #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

[FEATURE] add remote loader for runtime plugins #2514

merged 2 commits into from
Dec 20, 2024

Conversation

jgbernalp
Copy link
Contributor
@jgbernalp jgbernalp commented Dec 17, 2024 •
edited
Loading

Description

This PR uses the remote plugin loader to load all types of plugins at runtime, based on the installed plugins fetched from api/v1/plugins

This will work in conjunction with perses/plugins#16 and perses/plugins#18

@jgbernalp jgbernalp requested a review from Nexucis December 17, 2024 08:54
@jgbernalp jgbernalp force-pushed the feature/plugin-runtime-loader branch from 801ebe1 to c3a89e8 Compare December 17, 2024 09:00
@jgbernalp jgbernalp mentioned this pull request Dec 17, 2024
Merged
@Nexucis
Copy link
Member
Nexucis commented Dec 17, 2024 •
edited
Loading

looks like the e2e tests are broken but I suppose it's because it requires the new datasource plugin

Nexucis
Nexucis reviewed Dec 17, 2024
View reviewed changes
Nexucis
Nexucis reviewed Dec 17, 2024
View reviewed changes
@jgbernalp jgbernalp force-pushed the feature/plugin-runtime-loader branch from c3a89e8 to 4f79b3b Compare December 17, 2024 15:22
@jgbernalp
[FEATURE] add remote loader for runtime plugins
bf9d406 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the feature/plugin-runtime-loader branch from 4f79b3b to bf9d406 Compare December 17, 2024 15:28
Nexucis
Nexucis reviewed Dec 17, 2024
View reviewed changes
AntoineThebaud
AntoineThebaud reviewed Dec 18, 2024
View reviewed changes
@jgbernalp
Copy link
Contributor Author

I adjusted the plugin module structure to match better our types conventions as discussed. I added the changes from the plugins side here: perses/plugins#18

@jgbernalp jgbernalp force-pushed the feature/plugin-runtime-loader branch from 9a1223a to 3ac835d Compare December 19, 2024 18:27
@jgbernalp
[FEATURE] refactor plugin module definition
6e0ea0d 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the feature/plugin-runtime-loader branch from 3ac835d to 6e0ea0d Compare December 19, 2024 18:31
@Nexucis
Copy link
Member
Nexucis commented Dec 20, 2024

@jgbernalp PR looks good to me. I guess the failure of the e2e tests is due to the loading of the Prometheus datasource right ?

I mean since the datasource plugin is not present yet (because it's not published) then the e2e tests cannot work

@jgbernalp
Copy link
Contributor Author

yes exactly. I'll merge it then. Thnx for checking.

@jgbernalp jgbernalp merged commit 6369f26 into feature/plugin-runtime Dec 20, 2024
17 of 18 checks passed
@jgbernalp jgbernalp deleted the feature/plugin-runtime-loader branch December 20, 2024 08:59
@Nexucis Nexucis mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis left review comments

@AntoineThebaud AntoineThebaud AntoineThebaud left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgbernalp @Nexucis @AntoineThebaud
0