8000 [ENHANCEMENT] DaC CUE SDK: accurate constraints for duration attributes by AntoineThebaud · Pull Request #2525 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] DaC CUE SDK: accurate constraints for duration attributes #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

AntoineThebaud
Copy link
Contributor
@AntoineThebaud AntoineThebaud commented Dec 20, 2024

The patch file complements the generated file that actually defines no precise constraint:

// Code generated by cue get go. DO NOT EDIT.
//cue:generate cue get go github.com/perses/perses/pkg/model/api/v1/common
package common
// Duration wraps time.Duration. It is used to parse the custom duration format
// from YAML.
// This type should not propagate beyond the scope of input/output processing.
// +kubebuilder:validation:Type=string
// +kubebuilder:validation:Format=duration
// +kubebuilder:validation:Pattern=`^(([0-9]+)y)?(([0-9]+)w)?(([0-9]+)d)?(([0-9]+)h)?(([0-9]+)m)?(([0-9]+)s)?(([0-9]+)ms)?$`
#Duration: _

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review December 20, 2024 16:00
@AntoineThebaud AntoineThebaud added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 934117d Dec 20, 2024
18 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/dac-cue-duration branch December 20, 2024 16:13
Nexucis pushed a commit that referenced this pull request Jan 7, 2025
…es (#2525)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Nexucis added a commit that referenced this pull request Jan 15, 2025
* Release v0.50.0-rc.0 (#2515)

* Release v0.50.0-rc.0

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* fix comment

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

---------

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* [DOC] Align plugin doc with the migration revamp (#2516)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* [ENHANCEMENT] Table panel: editor text fields are debounced  (#2470)

* [FEATURE] Add debounce to TextField

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* forwardRef

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* fix tests

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [ENHANCEMENT] Table panel: text field inputs are debounced

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Fix tests

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

---------

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [BUGFIX] Table panel: fix cell mapping for range condition (#2517)

* [BUGFIX] Table panel: fix cell mapping when for range condition

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* More pretty

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Fix range not removable

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Ignore more domains

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

---------

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [ENHANCEMENT] Use Perses logo for the app loader (#2518)

* [ENHANCEMENT] Use Perses logo for the app loader

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Only one loader 🔥

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* Fix header 🐛

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* fix e2e

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

---------

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [BUGFIX] Fix preview display name with prefix (#2520)

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* [ENHANCEMENT] DaC CUE SDK: add datasource param to the var group builder (#2524)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* [ENHANCEMENT] DaC CUE SDK: accurate constraints for duration attributes (#2525)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* [ENHANCEMENT] `percli dac diff`: add output + avoid early return when processing a directory (#2500)

* [ENHANCEMENT] `percli dac diff`: avoid early return when processing a directory

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* add a proper output to the diff command

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* improve error handling as suggested

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

---------

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* [ENHANCEMENT] : percli plugin lint: improve the way to find the schema files (#2526)

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* [BUGFIX] DaC CUE SDK: Fix inconsistencies in mandatory vs optional attributes in dashboard lib (#2540)

* DaC CUE SDK: Fix inconsistencies in mandatory vs optional attributes in dashboard lib

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* misc: reorder params for clarity

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

---------

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* Release v0.50.0-rc.1 (#2543)

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* BUGFIX: `percli dac setup`: fix useless requirement of go CLI when using CUE (#2544)

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* [IGNORE] Correctly type useQuery fetch hooks error (#2546)

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>

* [BUGFIX] Redirect to the desired page after login success (#2354)

* [BUGFIX] Redirect to the desired page after login success

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>

* [BUGFIX] Redirect to the desired page after login success

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>

* [BUGFIX] Redirect after login keeping query params

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>

---------

Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>

* [BUGFIX] Fixes tooltip display in EDGE / IE (#2547)

Signed-off-by: Maxim KOTELNIKOV <maxim.kotelnikov@amadeus.com>

* [BUGFIX] GaugeChartPanel: fix empty state (#2548)

Show "No data" instead of "null" when the Gauge has no data.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* [BUGFIX] Update unit's migration (#2519)

* update unit's migrtaion (add decimal unit as default, when it's not defined in mapping list)

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* Update dashboard test's output for migration changes

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* fix unit+decimal migration

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* fix decimals migration

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* update migration tests

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* update dashboard migration output file

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* remove extra spaces from barchart test output

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

---------

Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>

* Release v0.50.0 (#2553)

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

---------

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
Signed-off-by: Maxim KOTELNIKOV <maxim.kotelnikov@amadeus.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>
Co-authored-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Co-authored-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Co-authored-by: Célian GARCIA <celian.garcia@amadeus.com>
Co-authored-by: Maxim Kotelnikov <info@impy.us>
Co-authored-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0