8000 [BUGFIX] add id to avoid setState loops, upgrade MUI grid by jgbernalp · Pull Request #2600 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] add id to avoid setState loops, upgrade MUI grid #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

[BUGFIX] add id to avoid setState loops, upgrade MUI grid #2600

merged 1 commit into from
Feb 4, 2025

Conversation

jgbernalp
Copy link
Contributor

Description

A bug in the MUI Grid library caused loop setState mui/mui-x#15721, the library was upgraded. Also for dashboards with the same name but in different projects there was a key collision.

Fixes: #2559

Screenshots

No UI changes

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@jgbernalp jgbernalp requested a review from Gladorme February 3, 2025 19:11
galangel
galangel approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor
@galangel galangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgbernalp
[BUGFIX] add id to avoid setState loops
48324d9 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the jgbernalp/fix-recent-dashboards-list branch from 78713f2 to 48324d9 Compare February 4, 2025 06:51
Gladorme
Gladorme approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member
@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Gladorme Gladorme added this pull request to the merge queue Feb 4, 2025
Nexucis
Nexucis approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olala this is so great you find where this issue was coming from !

Merged via the queue into main with commit 0099dca Feb 4, 2025
18 checks passed
@Gladorme Gladorme deleted the jgbernalp/fix-recent-dashboards-list branch February 4, 2025 09:46
@ibakshay
Copy link
Contributor
ibakshay com A37E mented Feb 4, 2025

wohooo! @jgbernalp you are awesome! 🚀🫡

jgbernalp added a commit that referenced this pull request Mar 13, 2025
@jgbernalp
[BUGFIX] add id to avoid setState loops (#2600)
51e8d95 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

@Gladorme Gladorme Gladorme approved these changes

@galangel galangel galangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React error #185 when connecting to my company's Perses instance
5 participants
@jgbernalp @ibakshay @Nexucis @Gladorme @galangel
0