8000 [BUGFIX] Uses pkg filepath instead of path when manipulating file access by Nexucis · Pull Request #2611 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] Uses pkg filepath instead of path when manipulating file access #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

[BUGFIX] Uses pkg filepath instead of path when manipulating file access #2611

merged 1 commit into from
Feb 6, 2025

Conversation

Nexucis
Copy link
Member
@Nexucis Nexucis commented Feb 6, 2025

We are using in various places path.Join or path.Split while using file access path that works everywhere than on windows.

This PR aims to fix that by using the pkg filepath that will handle the windows file system.

@Nexucis
[BUGFIX] Uses pkg filepath instead of path when manipulating file access
19a7ff2 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 35849ab Feb 6, 2025
18 checks passed
@Nexucis Nexucis deleted the nexucis/fix-usage-filepath branch February 6, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasgerstmayr andreasgerstmayr andreasgerstmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nexucis @andreasgerstmayr
0