8000 [ENHANCEMENT] Add Authorization and BasicAuth definitions to cue package by dougkirkley · Pull Request #2643 · perses/perses · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENHANCEMENT] Add Authorization and BasicAuth definitions to cue package #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

[ENHANCEMENT] Add Authorization and BasicAuth definitions to cue package #2643

merged 1 commit into from
Feb 13, 2025

Conversation

dougkirkley
Copy link
Contributor

Description

Adds the Authorization and BasicAuth definitions to the cue package because they are missed due to a cuelang limitation with types that have custom marshalling methods.

Closes #2638

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@dougkirkley
Add Authorization and BasicAuth definitions to cue package
1a0a950 
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
Nexucis
Nexucis approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member
@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank you !

@Nexucis Nexucis merged commit 48497a6 into perses:main Feb 13, 2025
18 checks passed
jgbernalp pushed a commit that referenced this pull request Mar 20, 2025
@dougkirkley @jgbernalp
Add Authorization and BasicAuth definitions to cue package (#2643)
6a65563 
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cuelang package secret is missing the Authorisation, BasicAuth and TLSConfig definition
2 participants
@dougkirkley @Nexucis
0