[ENHANCEMENT] rework percli plugin build to vendor CUE dependencies
#2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c7fa91 to
db4fe57
Compare
percli plugin build to vendor CUE dependencies
f1f54c8 to
09f0e9b
Compare
AntoineThebaud
commented
Mar 1, 2025
Nexucis
reviewed
Mar 1, 2025
Nexucis
reviewed
Mar 4, 2025
Nexucis
reviewed
Mar 4, 2025
d28357a to
9ccc712
Compare
AntoineThebaud
commented
Mar 4, 2025
303b92d to
40f9e5b
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
7b751d2 to
ea6504b
Compare
Nexucis
reviewed
Mar 5, 2025
Nexucis
approved these changes
Mar 5, 2025
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
e492488
into
feature/remove-plugin-schemas
19 checks passed
Nexucis
added a commit
that referenced
this pull request
Mar 5, 2025
* [BREAKINGCHANGE] CUE: rely on native dep management (#2645) * [BREAKINGCHANGE] Remove `percli plugin update` command (#2660) Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> * [ignore] use function LoadModelSchema in the discovery tests (#2661) Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * [IGNORE] change back module name to the right name (#2667) Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> * [ENHANCEMENT] rework `percli plugin build` to vendor CUE dependencies (#2695) * [ENHANCEMENT] rework `percli plugin build` to vendor CUE dependencies Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> --------- Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr> Signed-off-by: Augustin Husson <husson.augustin@gmail.com> Co-authored-by: Augustin Husson <husson.augustin@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a step of dependencies vendoring to the
percli plugin buildcommand.Why: Following the move to CUE native dependency management, the deps of the plugin are no longer vendored under
cue.mod/pkg. Letting things in this state would imply that, at runtime, the Perses server should have access to an OCI registry - thus either access to internet OR to a custom registry set up by users in their private network - to be able to evaluate a pluginschema that imports packages - like the
commonpackage of Perses.As we consider this constraint a no-go in our case, We looked for solutions to that problem... After asking to CUE
maintainers it seems our long term solution would be this native vendor command, yet to be implemented. cue-lang/cue#3328.
Thus for the time being we have to reproduce the vendoring structure of the "old-modules" with custom code.
Ref #1984
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.