PLib: Allow building for .NET Standard 2.1 #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
|
Can you rebase on HEAD? |
Wrap some stuff in preprocessor as it prevents compilation when using .NET Standard 2.1 (which ONI now uses). The functionality in question seems to be for debugging purposes only so it should not matter much. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
ONI now uses a cursed version of the Mono runtime that conforms to .NET Standard 2.1 which does not have an exact Microsoft equivalent. But one can still target the `netstandard2.1` framework while targetting a .NET Framework v4 runtime. This is a bit (very) cursed, but somehow works... I could not get MSBuild to behave the way I wanted it to, so I chose to override `TargetFrameworks` in the various PLib projects one by one. It is very likely there is a better way to go about this. Signed-off-by: Angel Pons <th3fanbus@gmail.com>
|
I wanted to do a rebase but GitHub did a merge commit... Should be fine now. |
|
Squashed the commits to avoid a mess with the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.