10000 Fix Vagrantfile for Vagrant 1.3.4 using 'Vagrant.configure('2') syntax by gregelin · Pull Request #4 · philippkueng/ckan-vagrant · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Vagrantfile for Vagrant 1.3.4 using 'Vagrant.configure('2') syntax #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Vagrantfile for Vagrant 1.3.4 using 'Vagrant.configure('2') syntax #4

wants to merge 3 commits into from
+116 −10

Conversation

gregelin
Copy link
@gregelin gregelin commented Nov 1, 2013 8000

The Vagrantfile was failing with Vagrant 1.3.4. This Vagrant file works.

However, I could not get the hostname directive to work, even after changing the syntax to hostname from host_name. I finally just commented. Whenever the vagrant up was run with the host name directive uncommented, the VM would be created and the provision would never run.

@gregelin
Copy link
Author
gregelin commented Nov 1, 2013

Vagrant fixed a bug in version 1.3.5 which allows config.vm.hostname to work again. (Note hostname and no longer host_name.)

I think my master will now be a head of yours. I may send another pull request.

@philippkueng
Copy link
Owner

Hi @gregelin
Sorry that it has taken me so long. It looks good, will test it within the next hour.
Could you remove the README from the pull request? Since you changed the url, and i'm not sure the output is necessary. However I like the license change :)

@ghost ghost assigned philippkueng Nov 5, 2013
@philippkueng
Copy link
Owner

Tested, everything works. Regarding the PR. ...i think i'll cherry pick the changes to the vagrant file you made. if that's ok with you.

@gregelin
Copy link
Author
gregelin commented Nov 5, 2013

That is fine. Do you still me need me to make the readme changes? And redo the pull request?

Sent from my iPhone

Greg Elin
e: gregelin@gitmachines.com
t: @gregelin
c: 917-304-3488

On Nov 5, 2013, at 10:59 AM, Philipp Küng notifications@github.com wrote:

Tested, everything works. Regarding the PR. ...i think i'll cherry pick the changes to the vagrant file you made. if that's ok with you.

—
Reply to this email directly or view it on GitHub.

@philippkueng
Copy link
Owner

Nope, i'll do it. Thanks for your help updating the project. Really appreciate it.

@gregelin
Copy link
Author
gregelin commented Nov 5, 2013

Thanks for the work you did!

Our mission at GitMachines is to make it easy for innovators to bring open source and new tech into security-minded institutions. Out goal is to create accreditation-ready configurations. CKAN is a tech/project identified as high value.

Sent from my iPhone

Gre 76A3 g Elin
e: gregelin@gitmachines.com
t: @gregelin
c: 917-304-3488

On Nov 5, 2013, at 11:09 AM, Philipp Küng notifications@github.com wrote:

Nope, i'll do it. Thanks for your help updating the project. Really appreciate it.

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philippkueng philippkueng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregelin @philippkueng
0