2.4.11 bugfix release #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed two bugs with JKTEBOP backend RVs. 1. To calculate RV semi-amplitude (K), system semi-major-axis was used previously instead of component sma (sma vs. center of mass). Before, any change in the mass ratio had no effect on the modelled rvs. 2. Small left-over discrepancy corrected, as RV amplitude K did not take eccentricity into account. Now includes term 1/(sqrt(1-ecc^2)). * added jktebop nosetest --------- Co-authored-by: Michael Abdul-Masih <michael.abdulmasih@gmail.com>
* fix minor syntax warning * update gitignore to avoid build files
* allow asini@star and sma@star to flip to solve for q
* Fixes spots on single rotating stars. Closes #716. * Rotstar optimization when spots are present A slight optimization that removes needless remeshing.
aprsa
added a commit
to aprsa/phoebe2
that referenced
this pull request
Oct 30, 2023
* constraint flipping bugfix (2.4.4 release) (phoebe-project#619) * fix bug where flipping Kepler's third law constraint multiple times would fail. * fix bug when flipping requivsumfrac and requivratio constraints. * update CI triggers rerun CI on updates to PR * negative mass bugfix (phoebe-project#635) * negative mass bugfix by setting min mass limit at 1e-12 Co-authored-by: Michael Abdul-Masih <michael.abdulmasih@gmail.com> * add missing analytical_model entry to lc_geometry API docs (phoebe-project#673) * potential to requiv TypeError bugfix (2.4.6 release) (phoebe-project#671) * fix bug where libphoebe was incorrectly raising an error suggesting the potential was out of bounds. * Line profile bugfix (2.4.7 release) (phoebe-project#637) * fix bug where wavelength arrays that did not include the central wavelength were returning nans for fluxes. * Fixed a wavelength coverage bug and added a new test. (phoebe-project#678) This first test incorrectly set the wavelength span from 0 to 1 instead of 549 to 551, which has been fixed. The new test checks whether internal interpolation works as expected. * CI rewrite (phoebe-project#688) * CI testing completely rewritten. Workflows are now separated by python versions; we support python 3.7 onwards. The idea here is to add new workflows for new python versions and retire old workflows for obsolete versions. * Deprecated nosetests replaced with pytest. All nose-specific code has been removed from all tests. * Several failing tests that should not be failing were added to the test exclusion list and appropriate tickets are opened. * All occurences to the obsolete np.int() and np.float() removed. While at it, some serious linting was performed on the affected sources. * Replaced ragged numpy arrays with lists. * Fixed dependency versioning war with subsequent pip install calls -- this is fragile and should be addressed. The poetry package should help significantly. * Added pyerfa and pyyaml to pip install (an astropy-5 dependency), and pipdeptree to the runtime process to see package dependencies. * Removed asdf from the list of packages. * Added matplotlib to the CI matrix. * Adds a private _remeshing_required() to Features (2.4.8 release) (phoebe-project#683) * spots no longer force the mesh to be recomputed at each timepoint. * updates for numpy compatibility and wider test matrix. * asynchronous spots bugfix (2.4.9 release) (phoebe-project#693) * fixes bug introduced in 2.4.8 and ensures that temperatures are recomputed for spots when the star is rotating asynchronously. * Adding MacOS-12 to CI (phoebe-project#715) * 2.4.10 bugfix release (phoebe-project#698) * fixes implementation of gravitational redshift. * fixes an unitialized value problem in gradients resulting in nans for effective temperatures. * minor updates to passband exporting to support upcoming 2.5 release on the passbands server. * allows setting SelectParameter to an array or tuple (in addition to a list). --------- Co-authored-by: Andrej Prsa <aprsa09@gmail.com> * New workflows for the CI. (phoebe-project#737) * New workflows for the CI. These workflows remove matplotlib checks and allow CI to run again. * Updating all tests to conditionally use matplotlib. * update pip requirements to lowest tested version in CI matrices * Macos-12 removed from python 3.7. Macos-12 uses python 3.8.9 or higher. --------- Co-authored-by: Kyle Conroy <kyleconroy@gmail.com> * 2.4.11 bugfix release (phoebe-project#723) * fix jktebop backend handling of mass-ratio and eccentricity for RVs. * bumps version requirements in pip for numpy, scipy, astropy. * allows sma@star and asini@star to flip to solve for q * fixes handling of spots on rotating single stars. * fixes constraint migration for 2.3 -> 2.4 --------- Co-authored-by: Jeppe Sinkbæk Thomsen <56873820+jsinkbaek@users.noreply.github.com> Co-authored-by: Michael Abdul-Masih <michael.abdulmasih@gmail.com> Co-authored-by: David Jones <Raindogjones@users.noreply.github.com> Co-authored-by: Andrej Prsa <aprsa09@gmail.com> --------- Co-authored-by: Kyle Conroy <kyleconroy@gmail.com> Co-authored-by: MichaelAbdul-Masih <40573575+MichaelAbdul-Masih@users.noreply.github.com> Co-authored-by: Michael Abdul-Masih <michael.abdulmasih@gmail.com> Co-authored-by: Jeppe Sinkbæk Thomsen <56873820+jsinkbaek@users.noreply.github.com> Co-authored-by: David Jones <Raindogjones@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog