Bugfix 2.4.12 #797
Merged
Bugfix 2.4.12 #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old versions of numpy could compare different length arrays element-wise (i.e., np.all(x==y) for x.shape != y.shape). That is no longer the case for numpy 1.24 onwards. Note that the fix uses len(x) instead of x.shape comparison to be more general, i.e. it works also if x and y are other types of iterables, not just ndarrays.
* Simplified CI run This workflow simplifies the testing matrix by using python 3.7 through 3.11 on [ubuntu,macos]-latest and pip installing all the latest versions of all dependencies. While less comprehensive than before, it arguably still catches all practical issues. * Fix test_rm numerical instability This test compared RVs to legacy for two identical stars, including exactly at conjunctions. That means that stars exactly overlapped, which is numerically unstable. The secondary star is now slightly smaller and slightly less massive. That causes RV of the secondary during secondary eclipse to be nan (because we can't see the star), so that timestamp is nan'd for the legacy as well, for comparison purposes. This now fixes the test and makes it numerically stable.
Fortran setup changed, see https://github.com/fortran-lang/setup-fortran. Attempting to apply the update.
In addition to the separate PR that removes distutils from setup.py, there were a number of distutils' LooseVersion() and StrictVersion() uses throughout the code. These have been replaced by packaging.version.parse.
Replaced `NotImplementedError` with `NotImplemented` Signed-off-by: fazledyn-or <ataf@openrefactory.com>
* Replacing the build system. The original distutils-based system has been replaced with setuptools and pyproject A043 .toml. C/C++ compiler version and flags are currently not checked; we should either re-implement the checks in setup.py or wait for PEP 725 (https://discuss.python.org/t/pep-725-specifying-external-dependencies-in-pyproject-toml/31888?page=1) to see the light of day. * Updates to the CI to build with the new system. * Cleaning up the build tree. This includes CI updates (adding optional modules) and renaming nosetests to tests. * Final touch: upgrading CI checkout versions. * Tidying up pyproject.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build system update: