8000 fix(reference/stream): HTTP Headers are U+0D U+0A (CRLF) separated by hakre · Pull Request #4740 · php/doc-en · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(reference/stream): HTTP Headers are U+0D U+0A (CRLF) separated #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 2 commits into from
Jun 22, 2025

Conversation

hakre
Copy link
Contributor
@hakre hakre commented Jun 22, 2025

compare Section 4.1 of RFC-2616 etc.

    generic-message = start-line
                      *(message-header CRLF)
                      CRLF
                      [ message-body ]

RFC-2616: https://www.rfc-editor.org/rfc/rfc2616#section-4.1
ok: /reference/stream/functions/stream-context-set-default.xml etc.

@hakre hakre marked this pull request as draft June 22, 2025 13:16
@hakre
Copy link
Contributor Author
hakre commented Jun 22, 2025

While double-checking against other examples below reference/stream I've seen that they can benefit from streamlining the improvements of #2956 (PHP 5.4 array syntax).

hakre added 2 commits June 22, 2025 15:53
correction of the formally wrong comment and place in the example code.

streamlining the example code style on separating multiple headers over multiple lines.

compare Section 4.1 of RFC-2616 etc.

        generic-message = start-line
                          *(message-header CRLF)
                          CRLF
                          [ message-body ]

RFC-2616: https://www.rfc-editor.org/rfc/rfc2616#section-4.1
ok: /reference/stream/functions/stream-context-set-default.xml etc.
in reference to 037266a ("fix(reference/stream): HTTP headers are U+0D U+0A (CR LF) separated", 2025-06-22) streamline by 'http' 'header' stream context option.
@hakre hakre marked this pull request as ready for review June 22, 2025 14:28
@hakre hakre requested a review from nielsdos as a code owner June 22, 2025 14:28
Copy link
Member
@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and nice improvements

@nielsdos nielsdos merged commit 3abd17e into php:master Jun 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0