Add an Authorization header if GITHUB_TOKEN is set #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwleuverink
approved these changes
Jun 4, 2025
|
Great find! Thanks for your contribution 🙏 |
|
I’ve released v0.4.0 which includes your fix 👍 |
|
Thanks for merging and releasing! |
|
Quick follow up: The next version of PHPacker will automatically detect your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I wanted to use PHPacker to create binaries for a CLI tool I'm making, but ran into an issue. PHPacker tries downloading from a GitHub repository, I assume to fetch the required runtimes. It does this, however, without any authentication. As I'm working on an IP that is constantly reaching the rate limits for anonymous requests, I need to authenticate my GitHub API calls. I've added basic support for this through this PR. If the
GITHUB_TOKENenvironment variable is set, anAuthorizationheader is passed to the GitHub API, allowing the requester to use the higher rate limits for authenticated requests.