Match form input/option element background colours to the overall the… #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me. Hardcoded #fff and absent background colour make dark contrast themes unreadable
houndci-bot
reviewed
Oct 30, 2018
| @@ -128,7 +128,7 @@ textarea.form-input { | |||
| } | |||
| } | |||
| &:not([multiple]):not([size]) { | |||
| background: #fff url("data:image/svg+xml;charset=utf8,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%204%205'%3E%3Cpath%20fill='%23667189'%20d='M2%200L0%202h4zm0%205L0%203h4z'/%3E%3C/svg%3E") no-repeat right .35rem center/.4rem .5rem; | |||
| background: $bg-color-light url("data:image/svg+xml;charset=utf8,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%204%205'%3E%3Cpath%20fill='%23667189'%20d='M2%200L0%202h4zm0%205L0%203h4z'/%3E%3C/svg%3E") no-repeat right .35rem center/.4rem .5rem; | |||
There was a problem hiding this comment.
center/.4rem should be written with a single space on each side of the operator: center / .4rem
| @@ -118,7 +118,7 @@ textarea.form-input { | |||
| padding: $control-padding-y $control-padding-x; | |||
| vertical-align: middle; | |||
| width: 100%; | |||
|
|
|||
| background: $bg-color-light; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a total CSS n00b, however there was a hardcoded #fff for a background colour and an absent background: specifier which made my darker theme impossible to read the text inside of a form.