8000 [Bug]: Fix nested block index by kingjia90 · Pull Request #18121 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Bug]: Fix nested block index #18121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: 11.5
Choose a base branch
from
Draft

[Bug]: Fix nested block index #18121

wants to merge 3 commits into from

Conversation

kingjia90
Copy link
Contributor
@kingjia90 kingjia90 commented Feb 18, 2025 •
edited
Loading

Changes in this pull request

Resolves #17927

Additional info

A little hacky&quick workaround... i am sure the real issue is somewhere inside this "dark area" http://github.com/pimcore/pimcore/blob/3322e055636b9e96a758bf858e02bafc82a3f75c/models/Document/Editable/Block.php#L111 😄

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 linked an issue Feb 18, 2025 that may be closed by this pull request
[Bug]: current value for nested pimcore blocks is wrong with new syntax #17927
Open
kingjia90
kingjia90 commented Apr 15, 2025
View reviewed changes
models/Document/Editable/Block.php
*/
public function setCurrent(int $current): void
{
$this->current = $current + 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 because the getCurrent() has a -1...

jdreesen
jdreesen reviewed Apr 15, 2025
View reviewed changes
@kingjia90 @jdreesen
Update lib/Twig/Node/BlockNode.php
3daf109 
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cadeyrn
Copy link
cadeyrn commented May 8, 2025

@kingjia90 Is the work on this PR blocked by something?

@kingjia90 kingjia 8000 90 added this to the 11.5.5 milestone May 8, 2025
@kingjia90
Copy link
Contributor Author
kingjia90 commented May 8, 2025 •
edited
Loading

@kingjia90 Is the work on this PR blocked by something?

Thank you for the reminder, i am waiting for a feedback from @brusch , my apologies for the long wait, this PR went under the radar as we were busy around the Inspire 2025, i am tagging him for a reminder as well

@cadeyrn
Copy link
cadeyrn commented May 8, 2025

No problem at all. I just wanted to make sure that it is not forgotten as long as Pimcore 11 is not yet EOL. 😀 Thanks for working on it!

@kingjia90 kingjia90 modified the milestones: 11.5.5, 11.5.6 Jun 3, 2025
@herbertroth herbertroth modified the milestones: 11.5.6, 11.5.7 Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

Assignees

@kingjia90 kingjia90

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.5.7
Development

Successfully merging this pull request may close these issues.

[Bug]: current value for nested pimcore blocks is wrong with new syntax
4 participants
@kingjia90 @cadeyrn @jdreesen @herbertroth
0