Support link generator for mockup objects #10938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankse
reviewed
Dec 2, 2021
bundles/EcommerceFrameworkBundle/Model/LinkGeneratorAwareInterface.php
Outdated
Show resolved
Hide resolved
jdreesen
reviewed
Dec 2, 2021
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
dvesh3
reviewed
Dec 6, 2021
blankse
reviewed
Dec 9, 2021
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
jdreesen
reviewed
Dec 9, 2021
Comment on lines
+24
to
+25
| * If you want to support mockups or arbitrary objects you can change the typehint to | ||
| * public function generate(object $object, array $params = []): string |
There was a problem hiding this comment.
Do we really need this comment? That's basic PHP contravariance behavior, so you could basically add this to every method...
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
|
@ckogler-elements thanks! |
kingjia90
added a commit
that referenced
this pull request
Mar 13, 2023
kingjia90
added a commit
that referenced
this pull request
Mar 14, 2023
kingjia90
added a commit
that referenced
this pull request
Mar 14, 2023
martineiber
added a commit
that referenced
this pull request
Mar 22, 2023
* task: move ecommerce events to bundle * task: follow-up #10938 * task: make event doc url relative * task: doublecheck object if has getLinkGenerator method * task: remove not found events * Update doc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md Co-authored-by: Martin Eiber <martin.eiber@pimcore.com> --------- Co-authored-by: Martin Eiber <martin.eiber@pimcore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to use link generators for mockup objects.
This leads to the problem, that in some places you can use {{ pimcore_url({'object': product}) }} because you have the orgininal object and in other cases {{ pimcore_url({'object': product}) }} won't work because you have a mockup object....
This PR adds support for Link generators with Mockup objects...