8000 [Perspective] Omit "not allowed perspective"-warning with perspective as GET by ferdinand-it · Pull Request #11262 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Perspective] Omit "not allowed perspective"-warning with perspective as GET #11262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

[Perspective] Omit "not allowed perspective"-warning with perspective as GET #11262

merged 1 commit into from
Jan 25, 2022

Conversation

ferdinand-it
Copy link
Contributor

With the default installation every time reloading the admin UI with the default GET-parameter "&perspective=", a WARNING "User pimcore is not allowed requested perspective ." is logged. But as seen a few lines above, this is not stated as a request for a new perspective. "Perspective for user {user} was not requested." as debug log makes sense here which is logged after this change.

Additionally, fixed wording in a warning log-message.

Rebased on 10.2 as requested #11255 (comment)

@ferdinand-it
[Perspective] Omit "not allowed perspective"-warning with perspective…
33e6ebc 
…= as GET

With the default installation every time reloading the admin UI with the default GET-parameter "&perspective=", a WARNING "User pimcore is not allowed requested perspective ." is logged. But as seen a few lines above, this is not stated as a request for a new perspective. "Perspective for user {user} was not requested." as debug log makes sense here which is logged after this change.

Additionally, fixed wording in a warning log-message.
@ferdinand-it ferdinand-it mentioned this pull request Jan 24, 2022
Closed
@dvesh3 dvesh3 added the Bug label Jan 24, 2022
@dvesh3 dvesh3 added this to the 10.2.10 milestone Jan 24, 2022
@dvesh3 dvesh3 requested a review from kingjia90 January 24, 2022 15:09
@kingjia90 kingjia90 merged commit 06ac843 into pimcore:10.2 Jan 25, 2022
@kingjia90 kingjia90 mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjia90 kingjia90 Awaiting requested review from kingjia90

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
10.2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@ferdinand-it @dvesh3 @kingjia90
0