8000 Fix: Exception thrown in "Search Assets" window by blankse · Pull Request #11303 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Exception thrown in "Search Assets" window #11303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

blankse
Copy link
Contributor
@blankse blankse commented Jan 30, 2022

Fix #11281

@BabovicT
Copy link
Contributor

@blankse it does fix the part where exception is thrown but now there is another bug. Go to dociment search for example and press the path. Now because type param is not send, after you press it, you see resoults for everything nit just documents.

@blankse
Copy link
Contributor Author
blankse commented Jan 30, 2022

@BabovicT Fix this bug also.

@blankse blankse force-pushed the fix_search_query_null branch from 85df0a3 to b9c85d9 Compare January 31, 2022 07:59
@brusch
Copy link
Member
brusch commented Jan 31, 2022

@blankse thanks a lot for your PR, however, since it's a bug fix, it should be based on 10.2 branch, right? Could you please rebase? Thanks in advance!

@brusch brusch added this to the 10.2.10 milestone Jan 31, 2022
@brusch brusch added the Bug label Jan 31, 2022
@blankse blankse changed the base branch from 10.x to 10.2 January 31, 2022 14:30
@blankse
Copy link
Contributor Author
blankse commented Jan 31, 2022

@brusch Was created for 10.2 :) Only the branch in PR was wrong. Now it should be correct.

@mcop1
Copy link
Contributor
mcop1 commented Feb 1, 2022

Looks great, thanks!

@mcop1 mcop1 merged commit efe3a1b into pimcore:10.2 Feb 1, 2022
@blankse blankse deleted the fix_search_query_null branch February 1, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Exception thrown in "Search Assets" window
4 participants
0