Check if kernel has booted when checking availability of the container #11635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
|
LGTM, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my very specific use case, I'm trying to read class definition files before loading the kernel. When including php files of class definition some calls are made to the Pimcore Runtime cache. This is fine because the runtime cache exposes a method that checks if the container is available before trying to initialize the cache instance.
The only problem is that
Symfony\Component\HttpKernel\Kernel::getContainerthrows an error when the kernel hasn't booted yet. Which in turn causes the runtime cache to fail.I have added a try catch clause to the hasContainer check to make sure the kernel has also booted.