8000 Add info about naming strategy to update guide by Cruiser13 · Pull Request #13658 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add info about naming strategy to update guide #13658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

Cruiser13
Copy link
Contributor

Changes in this pull request

docs only

@github-actions
Copy link
github-actions bot commented Nov 22, 2022

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dvesh3 dvesh3 added this to the 10.5.12 milestone Nov 28, 2022
@aryaantony92 aryaantony92 merged commit 1ae4fcf into pimcore:10.5 Nov 28, 2022
@aryaantony92
Copy link
Contributor

@Cruiser13 Thank you!

@BlackbitDevs
Copy link
Contributor
BlackbitDevs commented Dec 8, 2022

@Cruiser13 Did the migration of the editable naming strategy work for you? We had serious problems. At first the strategy services were not public and thus could not be loaded in the command class. Ok, was easy to fix.

Then we tried migrating a single document. Some did not work at all (afterwards the documents were simply empty (yes, we changed the naming strategy in the YML file after the migration). For some others it worked.
When we tested the command with single documents when a document includes a snippet in the footer, this does also get migrated (so imho the -d parameter is not strict enough) - and then with the next document it complained about that the footer document was already migrated.

Ok, so we thought we have to migrate all documents at once. This also did not work because the command aborted on the first error it gets - even if other documents worked perfectly when we converted them as single document with -d parameter.

So all in all, we had to give up and copy the contents manually. Maybe this was because of the project which has been touched by a lot of people over the last decade. But I am curious if you had a better experience...

@Cruiser13 Cruiser13 deleted the patch-15 branch December 8, 2022 14:28
@Cruiser13
Copy link
Contributor Author

@BlackbitDevs we did the migration using the render strategy on 6.9.6 and have been able to update smoothly to pimcore X afterwards, yes. We had some errors thrown on rendering first (warnings like "var not defined") so we fixed them and retried. It worked fine for us but I guess you might run into errors depending on the structure of your project (for things like the footer). We did not have editables in includes for example, we used snippets here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0