8000 [Documents] Fix non-reloading areabricks editable to have correct translation by dvesh3 · Pull Request #13748 · pimcore/pimcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Documents] Fix non-reloading areabricks editable to have correct translation #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

[Documents] Fix non-reloading areabricks editable to have correct translation #13748

merged 1 commit into from
Dec 6, 2022

Conversation

dvesh3
Copy link
Contributor
@dvesh3 dvesh3 commented Dec 6, 2022

Changes in this pull request

Resolves #13695

Additional info

@dvesh3 dvesh3 added the Bug label Dec 6, 2022
@dvesh3 dvesh3 added this to the 10.5.12 milestone Dec 6, 2022
@github-actions
Copy link
github-actions bot commented Dec 6, 2022

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

mattamon
mattamon approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor
@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended now!

@mattamon mattamon merged commit c711ae1 into 10.5 Dec 6, 2022
@mattamon mattamon deleted the fix_nonreloading_areabricks_translation branch December 6, 2022 14:09
@mattamon mattamon linked an issue Dec 6, 2022 that may be closed by this pull request
[Bug]: Editable loads static translated messages in wrong language #13695
Closed
@mattamon mattamon mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@mattamon mattamon

Labels
Bug
Projects
None yet
Milestone
10.5.12
Development

Successfully merging this pull request may close these issues.

[Bug]: Editable loads static translated messages in wrong language
2 participants
@dvesh3 @mattamon
0