remove loong64 arch in release notes v8.5.2 (#21198) #21199
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, an automated cherry-pick, updates the release notes for TiDB version 8.5.2. The primary change involves removing an entry that previously stated support for compilation and building on the Loongson loong64 architecture, ensuring the documentation accurately reflects the current state for this specific release.
Highlights
- Documentation Update: Removed a specific entry related to Loongson loong64 architecture support from the TiDB 8.5.2 release notes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes a single line item from the TiDB v8.5.2 release notes, specifically the mention of TiDB supporting compilation and building on the Loongson loong64 architecture.
Assuming this removal is to ensure factual accuracy (i.e., this support is not included in TiDB v8.5.2), the change is appropriate and improves the technical correctness of the documentation. The removal is clean and the resulting Markdown structure remains valid and well-formatted, adhering to the style guidelines for lists and spacing.
Style Guide Reference:
The review considered the provided "Documentation Review Style Guide", particularly focusing on:
- Technical Accuracy (Style Guide lines 14, 16): The change enhances accuracy if the feature is not part of the release.
- Clarity and Simplicity (Style Guide line 14): Removing incorrect information contributes to clearer documentation.
- Markdown Formatting (Style Guide line 38): The resulting document structure, including blank lines around list items, continues to adhere to the specified Markdown style.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21198
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?