8000 *: rename TiProxy to tiproxy in go import by djshow832 · Pull Request #353 · pingcap/tiproxy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

*: rename TiProxy to tiproxy in go import #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

*: rename TiProxy to tiproxy in go import #353

merged 1 commit into from
Sep 1, 2023

Conversation

djshow832
Copy link
Collaborator
@djshow832 djshow832 commented Sep 1, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #352

Problem Summary:
Rename TiProxy to tiproxy.

What is changed and how it works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox September 1, 2023 06:50
@purelind
Copy link
Contributor
purelind commented Sep 1, 2023

/test ?

1 similar comment
@purelind
Copy link
Contributor
purelind commented Sep 1, 2023

/test ?

@ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 1, 2023

@purelind: No presubmit jobs available for pingcap/tiproxy@main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 1, 2023
@ti-chi-bot
Copy link
ti-chi-bot bot commented Sep 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-01 07:17:09.253556351 +0000 UTC m=+2084193.802572322: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 1, 2023
@purelind
Copy link
Contributor
purelind commented Sep 1, 2023

/hold

@purelind
Copy link
Contributor
purelind commented Sep 1, 2023

/test all

@purelind
Copy link
Contributor
purelind commented Sep 1, 2023

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 8551648 into pingcap:main Sep 1, 2023
@djshow832 djshow832 deleted the update_import branch September 1, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TiProxy to tiproxy
3 participants
@djshow832 @purelind @xhebox
0