8000 TTSService: do not push LLMFullResponseEndFrame if not needed by aconchillo · Pull Request #1681 · pipecat-ai/pipecat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TTSService: do not push LLMFullResponseEndFrame if not needed #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

TTSService: do not push LLMFullResponseEndFrame if not needed #1681

merged 1 commit into from
Apr 28, 2025

Conversation

aconchillo
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

The assistant aggregator uses LLMFullResponseStartFrame and LLMFullResponseEndFrame to aggregate assistant output to the context. However, when using TTSSpeakFrame the TTS services were generating an LLMFullResponseEndFrame automatically. This was causing issues in the aggregator.

@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/services/tts_service.py 0.00% 10 Missing ⚠️
src/pipecat/services/elevenlabs/tts.py 0.00% 2 Missing ⚠️
src/pipecat/services/cartesia/tts.py 0.00% 1 Missing ⚠️
src/pipecat/services/rime/tts.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/services/cartesia/tts.py 0.00% <0.00%> (ø)
src/pipecat/services/rime/tts.py 0.00% <0.00%> (ø)
src/pipecat/services/elevenlabs/tts.py 0.00% <0.00%> (ø)
src/pipecat/services/tts_service.py 39.88% <0.00%> (-0.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
8000

markbackman
markbackman approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor
@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aconchillo aconchillo merged commit 8accd3e into main Apr 28, 2025
5 of 6 checks passed
@aconchillo aconchillo deleted the aleix/tts-service-llm-full-response-end-fix branch April 28, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbackman markbackman markbackman approved these changes

@filipi87 filipi87 Awaiting requested review from filipi87

Assignees
No one assigned
Labels
None yet
Projects
None yet
3DCF
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aconchillo @markbackman
0