8000 Fix: SimliVideoService was continuously emitting audio, preventing Bo… by markbackman · Pull Request #1721 · pipecat-ai/pipecat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: SimliVideoService was continuously emitting audio, preventing Bo… #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Fix: SimliVideoService was continuously emitting audio, preventing Bo… #1721

merged 1 commit into from
May 2, 2025

Conversation

markbackman
Copy link
Contributor

…tStoppedSpeakingFrame from being sent

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Thanks to the work done here: #1624

@markbackman markbackman requested review from aconchillo and filipi87 May 2, 2025 20:34
@codecov Codecov
Copy link
codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/services/simli/video.py 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/services/simli/video.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@markbackman markbackman mentioned this pull request May 2, 2025
Closed
filipi87
filipi87 approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor
@filipi87 filipi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markbackman markbackman merged commit e6aadac into main May 2, 2025
6 checks passed
@markbackman markbackman deleted the mb/simli-silent-frames branch May 2, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipi87 filipi87 filipi87 approved these changes

@aconchillo aconchillo Awaiting requested review from aconchillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markbackman @filipi87
0