fix: proxy giphy and tenor searches to avoid api key leakage #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that you are templating the api keys for giphy and tenor in the
index.html. That leaks the api key to everyone who has access to your proxy.This PR adds new http endpoints, so the backend does the actual api calls to giphy/tenor. This way the api key will never be publicly visible.
BTW the randomly generated bearer token that protects the
/api/localendpoint gets leaked, too. That makes the auth basically useless, if you're lucky it will prevent some automated scanners from accessing this endpoint, but that's about it.