Bugfix: Calculation of next date when date is start of year #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fhasse95 Thank you so much for fixing the bug and adding the tests! Looks great! I'll include it in v0.2.4. |
|
Just released 0.2.4. Thank you again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pixyzehn,
first of all, thank you for all your hard work on this library! It's really great and I've enjoyed using it in my projects.
However, while working with the library, I came across a small bug: When using a date like January 1st for the yearly recurrence, the calculation would incorrectly skip a year. After investigating, I found that the problem was caused by a missing
.addingTimeInterval(-1)adjustment.This pull request resolves this issue by ensuring that the recurrence logic handles this case as expected. In addition, I've added some unit tests to verify the fix and prevent regressions in the future.
Thank you for considering this fix!
Best regards,
Fabian