10000 Fix some typos by singiamtel · Pull Request #40 · pkmn/ps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some typos #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import {Generations} from '@pkmn/data';
const dexGens = new Generations(dex.Dex);

// All of the types from sim.Dex don't actually line up perfectly, but casting sidesteps that
const simGens = new Generations(sim.Dex as uknown as Dex);
const simGens = new Generations(sim.Dex as unknown as Dex);
```

### `Generations`
Expand Down Expand Up @@ -72,7 +72,7 @@ a couple of Pokémon Showdown quirks. While this interface is far from the
`Dex#stats` which just provides some lists of names).
- a usable `Learnsets` API which allows you to easily determine which moves a Pokémon can legally
learn (though validating combinations of moves or other features requires `@pkmn/sim`'s
`TeamValidator` - something as seemingly simple as determing Galar move legality cannot be
`TeamValidator` - something as seemingly simple as determining Galar move legality cannot be
generally solved without the full power of the `TeamValidator`).

**`Generations` handles existence at the field level slightly differently than at the object level**
Expand Down Expand Up @@ -119,7 +119,7 @@ the `Generations` constructor:

```ts
// These species are unobtainable outside of their own generations, but @pkmn/dex doesn't contain
// the artificial 'natDexTier' field which allows Pokémon Showdown to track this so we harcode it.
// the artificial 'natDexTier' field which allows Pokémon Showdown to track this so we hardcode it.
// If using @pkmn/sim instead, this list can be replaced with a `d.natDexTier !== 'Illegal'` check.
const NATDEX_UNOBTAINABLE_SPECIES = [
'Eevee-Starter', 'Floette-Eternal', 'Pichu-Spiky-eared', 'Pikachu-Belle', 'Pikachu-Cosplay',
Expand Down
2 changes: 1 addition & 1 deletion img/import-data
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ const NODEX = new Set([
'pikachulibre', 'pikachuphd', 'pikachupopstar', 'pikachubelle', 'pikachurockstar',
]);

// FIXME: ideally this list should be unnecesary and shiny sprites would be added
// FIXME: ideally this list should be unnecessary and shiny sprites would be added
const MISSING = {
chesnaught: ['gen5ani-shiny', 'gen5ani-back-shiny'],
corviknight: ['gen5ani-shiny'],
Expand Down
2 changes: 1 addition & 1 deletion integration/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ following additional flags may be used:
just once. If `--cycles` is negative, `--forever` is implied.
- **`--forever`**: continue iterating through formats infinitely, exhausting
each `--cycles` times.
- **`--maxFailures`**: exit early if this many failures have occured.
- **`--maxFailures`**: exit early if this many failures have occurred.
2 changes: 1 addition & 1 deletion integration/build-client
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ process.stdout.write("Building `data/teambuilder-tables.js`... ");
}
}

// Client relevant data that should be overriden by past gens and mods
// Client relevant data that should be overridden by past gens and mods
const overrideSpeciesKeys = ['abilities', 'baseStats', 'cosmeticFormes', 'isNonstandard', 'requiredItems', 'types', 'unreleasedHidden'];
const overrideMoveKeys = ['accuracy', 'basePower', 'category', 'desc', 'flags', 'isNonstandard', 'pp', 'priority', 'shortDesc', 'target', 'type'];
const overrideAbilityKeys = ['desc', 'flags', 'isNonstandard', 'rating', 'shortDesc'];
Expand Down
2 changes: 1 addition & 1 deletion mods/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The `ModdedDex` wrapper class around `Dex` exists for typechecking purposes as w
contains entirely new fields, `ModdedDex` (initialized with the correct types as parameters) will
allow for presenting a typesafe API to clients (though internally relies on casting, which is not
guaranteed to be safe). There are cleaner ways to implement typesafe mods, but this `ModdedDex`
approach aims to simply acheive parity with the upstream Pokémon Showdown implementation.
approach aims to simply achieve parity with the upstream Pokémon Showdown implementation.

```ts
import {Dex, ID, ModData, Ability, AbilityData} from '@pkmn/dex'; // '@pkmn/sim'
Expand Down
2 changes: 1 addition & 1 deletion protocol/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Parsing logic for [Pokémon Showdown](https://pokemonshowdown.com)'s
[SIM-PROTOCOL](https://github.com/smogon/pokemon-showdown/blob/master/sim/SIM-PROTOCOL.md).

This package converts Pokémon Showdown's text protocols into typed object
respresentations for ease of use.
representations for ease of use.

## Installation

Expand Down
6 changes: 3 additions & 3 deletions protocol/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ export namespace Protocol {
/**
* `|uhtml|NAME|HTML`
*
* We recieved an HTML message (NAME) that can change what it's displaying, this is used in
* We received an HTML message (NAME) that can change what it's displaying, this is used in
* things like our Polls system, for example.
*/
'|uhtml|': readonly ['uhtml', UHTMLName, HTML];
Expand Down Expand Up @@ -1004,7 +1004,7 @@ export namespace Protocol {
* `|t:|TIMESTAMP`
*
* The current UNIX timestamp (the number of seconds since 1970) - useful for determining
* when events occured in real time.
* when events occurred in real time.
*/
'|t:|': readonly ['t:', Timestamp];
}
Expand Down Expand Up @@ -1114,7 +1114,7 @@ export namespace Protocol {
/**
* `|-fail|POKEMON|ACTION`
*
* The specified `ACTION` has failed against the `POKEMON` targetted. The `ACTION` in question
* The specified `ACTION` has failed against the `POKEMON` targeted. The `ACTION` in question
* should be a move that fails due to its own mechanics. Moves (or effect activations) that fail
* because they're blocked by another effect should use `-block` instead.
*/
Expand Down
2 changes: 1 addition & 1 deletion sets/src/test/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {GenerationNum, StatsTable} from '@pkmn/types';
import {Data, toID} from '../sets';

const ABILITIES: {[id: string]: string} = {
justifed: 'Justified',
justified: 'Justified',
levitate: 'Levitate',
magicguard: 'Magic Guard',
magnetpull: 'Magnet Pull',
Expand Down
4 changes: 2 additions & 2 deletions view/src/choices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class ChoiceBuilder {
alreadyMega = false;
alreadyMax = false;
alreadyZ = false;
alreadTera = false;
alreadyTera = false;

constructor(request: Protocol.Request) {
this.request = request;
Expand Down Expand Up @@ -129,7 +129,7 @@ export class ChoiceBuilder {
if (choice.mega) this.alreadyMega = true;
if (choice.z) this.alreadyZ = true;
if (choice.max) this.alreadyMax = true;
if (choice.tera) this.alreadTera = true;
if (choice.tera) this.alreadyTera = true;
this.current.move = 0;
this.current.mega = false;
this.current.ultra = false;
Expand Down
0