8000 Fix exports by singiamtel · Pull Request #39 · pkmn/ps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix exports #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix exports #39

wants to merge 1 commit into from

Conversation

singiamtel
Copy link
Contributor

Please describe your fix:

Properly export TS types as such

Bug:

This breaks testing on bun. Not very relevant but still neat to get it fixed

Testing:

Run `npm run build && bun test``, it should be green now

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation where necessary
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have split off unrelated changes into their own PRs and done my best to make this PR as
    focused as possible while still being useful

@scheibo
Copy link
Contributor
scheibo commented May 2, 2025

In general Jarred wants issues like these to be filed against Bun instead of the respective projects.

Also, is this really the only place in the whole tree that needs to be updated? Im suprised nothing else exports types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singiamtel @scheibo
0