8000 Revert "solve compile failed in larger 3.0.0, lua-5.1 (closes #122)." by solemnwarning · Pull Request #140 · pkulchenko/wxlua · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "solve compile failed in larger 3.0.0, lua-5.1 (closes #122)." #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "solve compile failed in larger 3.0.0, lua-5.1 (closes #122)." #140

wants to merge 1 commit into from

Conversation

solemnwarning
Copy link
Contributor

This reverts commit bde906e.

I'm not sure what the original problem this was trying to resolve, but moving the wxDEFINE_EVENT macros into wxlstate.h duplicates the event definitions and leads to different translation units having different IDs for the same events.

@solemnwarning solemnwarning mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solemnwarning
0