8000 JACOBIN-680, 683, 684, 686, 687 by texadactyl · Pull Request #300 · platypusguy/jacobin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JACOBIN-680, 683, 684, 686, 687 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 5, 2025
Merged

JACOBIN-680, 683, 684, 686, 687 #300

merged 12 commits into from
Mar 5, 2025

Conversation

texadactyl
Copy link
Collaborator
@texadactyl texadactyl commented Mar 3, 2025 •
edited
Loading

gfunction

  • jj_test.go - TestJjStringifyScalar_RefNonNull: InitGlobals("test").

jvm

  • runUtils.go - JACOBIN-683 getSuperclasses() failed to diagnose nil return from MethAreaFetch.
  • runUtils_test.go - JACOBIN-680 expanded coverage for runUtils.go to 80%.

object

  • format.go - handle JavaByte arrays better.
  • format_test.go
    • JACOBIN-687 TestFmtHelper(). Expanded coverage to 75%.
    • JACOBIN-684 avoid GetStaticValue crash by setting up globals.FuncThrowException.
  • string.go - new func: StringPoolIndexFromGoString.

statics

  • statics.go - correct comments.

@texadactyl texadactyl requested a review from platypusguy March 3, 2025 19:44
@platypusguy
Copy link
Owner

Thanks for these edits! See my comments to the various entries, notably, JACOBIN-683, JACOBIN-684, JACOBIN-686 in YouTrack and let's decide those before merging this.

@platypusguy platypusguy merged commit be02f37 into platypusguy:main Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platypusguy platypusguy Awaiting requested review from platypusguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texadactyl @platypusguy
0