8000 🔐 SPFx toolkit should support login over your own app reg · Issue #291 · pnp/vscode-viva · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🔐 SPFx toolkit should support login over your own app reg #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 of 7 tasks
Adam-it opened this issue Aug 18, 2024 · 1 comment · Fixed by #296 or #298
Closed
6 of 7 tasks

🔐 SPFx toolkit should support login over your own app reg #291

Adam-it opened this issue Aug 18, 2024 · 1 comment · Fixed by #296 or #298
Assignees
@Adam-it
Labels
👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 👨‍💻work in progress I am working on it
Milestone
v4.0

Comments

@Adam-it
Copy link
Member
Adam-it commented Aug 18, 2024 •
edited
Loading

Due to upcoming changes we need to adapt the product so that it will be possible to login over your own app reg.
We need to:

  • add functionality to provide client id and tenant id when sign in
  • add more support for the modified login process vs code walkthrough
  • add more guidance on how to set up such an app with some copy paste methods over products user could already have. SPFx toolkit could even initially install for example AZ CLI so that this may be ready
  • add error handling with notify redirecting to login page when enterprise app is missing
  • update wiki
  • create blog post
  • create a recording to be used
@Adam-it Adam-it added 👨‍💻work in progress I am working on it ✏️prototype 👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 labels Aug 18, 2024
@Adam-it Adam-it self-assigned this Aug 18, 2024
@Adam-it Adam-it changed the title SPFx toolkit should support login over your own app reg 🔐 SPFx toolkit should support login over your own app reg Aug 18, 2024
@Adam-it Adam-it mentioned this issue Sep 6, 2024
Merged
6 tasks
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
d79ac32 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
@Adam-it Adam-it modified the milestones: v5.0, v4 Sep 8, 2024
@Adam-it
Copy link
Member Author
Adam-it commented Sep 8, 2024

This will be merged shortly

@Adam-it Adam-it mentioned this issue Sep 8, 2024
Merged
9 tasks
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
083d2e9 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
@Adam-it Adam-it closed this as completed in 5359569 Sep 8, 2024
nicodecleyre added a commit to nicodecleyre/vscode-viva that referenced this issue Oct 20, 2024
@Adam-it @GuidoZam
@Saurabh7019 @DevPio @nicodecleyre
Release v4.0.0 (pnp#298)
07abd07 
## 🎯 Aim

The aim is to prepare a new major release with the latest changes that
introduced improvements in the welcome experience, filter sample
gallery, settings and new login experience.

## 📷 Result


![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/bc27ede2-368f-40ff-9222-f9c02cedd857)


![sign-in-options](https://github.com/user-attachments/assets/c36c1886-cfed-44eb-8bb9-c706c9b166eb)


![settings](https://github.com/user-attachments/assets/509653cd-0c38-4c5d-8c63-cfd7a63976e7)

## ✅ What was done

- [X] Updated Sign in method
- [X] Updated SPFx Intro and workspace setup walkthrough steps
- [X] Updated readme assets
- [X] Added form to create Entra App Registration required for sign in
- [X] Added Extension filter dropdown to the sample gallery
- [X] Updated account view to show the Entra App Registration
- [X] Updated terminal usage to unified approach
- [X] Updated release workflows
- [X] Added settings to show and hide health incidents and tenant wide
extensions

## 🔗 Related issue

Closes: pnp#291

---------

Co-authored-by: Guido Zambarda <guido@piasys.it>
Co-authored-by: Saurabh Tripathi <saurabh.tripathi@epicalgroup.com>
Co-authored-by: Luccas Castro <64063580+DevPio@users.noreply.github.com>
Co-authored-by: Nico De Cleyre <35696168+nicodecleyre@users.noreply.github.com>
nicodecleyre added a commit to nicodecleyre/vscode-viva that referenced this issue Apr 19, 2025
@Adam-it @GuidoZam
@Saurabh7019 @DevPio @nicodecleyre
Release v4.0.0 (pnp#298)
d6cbfae 
## 🎯 Aim

The aim is to prepare a new major release with the latest changes that
introduced improvements in the welcome experience, filter sample
gallery, settings and new login experience.

## 📷 Result


![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/bc27ede2-368f-40ff-9222-f9c02cedd857)


![sign-in-options](https://github.com/user-attachments/assets/c36c1886-cfed-44eb-8bb9-c706c9b166eb)


![settings](https://github.com/user-attachments/assets/509653cd-0c38-4c5d-8c63-cfd7a63976e7)

## ✅ What was done

- [X] Updated Sign in method
- [X] Updated SPFx Intro and workspace setup walkthrough steps
- [X] Updated readme assets
- [X] Added form to create Entra App Registration required for sign in
- [X] Added Extension filter dropdown to the sample gallery
- [X] Updated account view to show the Entra App Registration
- [X] Updated terminal usage to unified approach
- [X] Updated release workflows
- [X] Added settings to show and hide health incidents and tenant wide
extensions

## 🔗 Related issue

Closes: pnp#291

---------

Co-authored-by: Guido Zambarda <guido@piasys.it>
Co-authored-by: Saurabh Tripathi <saurabh.tripathi@epicalgroup.com>
Co-authored-by: Luccas Castro <64063580+DevPio@users.noreply.github.com>
Co-authored-by: Nico De Cleyre <35696168+nicodecleyre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v4.0
1 participant
@Adam-it
0